-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Build a xDSL-embedding Pyodide distribution. #328
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is certainly a good step in the right direction!
Codecov ReportBase: 90.18% // Head: 88.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 90.18% 88.87% -1.31%
==========================================
Files 52 60 +8
Lines 7149 7595 +446
Branches 1176 1238 +62
==========================================
+ Hits 6447 6750 +303
- Misses 460 591 +131
- Partials 242 254 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor proposal, than another review and we could merge I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me!
This PR now builds a custom Pyodide distribution, embedding xDSL and dependencies, so we can just
import xdsl
in JupyterLite, as desired. It should also improve startup time.This can be previewed at papychacal.github.io/xdsl
Note you might need to clear your browser's cache for the page, especially if you get some "hash mismatch" error on importing xDSL.
The Pyodide build is cached, so it should take less than 5 minutes once cached.